Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis dependency to 7.2.4 #507

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Update Redis dependency to 7.2.4 #507

merged 2 commits into from
Feb 29, 2024

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Feb 28, 2024

A fix in the build scripts of Redis 7.2.4 modifies build behavior on MacOS on Apple Silicon. The change fixes an issue where incorrect compiler flags are defined and result in build failures due to the redis_fstat macro

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (b44ef3a) to head (119ba1e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #507   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files           60       60           
  Lines         3838     3838           
========================================
  Hits          3483     3483           
  Misses         355      355           
Files Coverage Δ
smartsim/_core/utils/redis.py 80.39% <ø> (ø)

@ankona ankona requested a review from ashao February 29, 2024 22:43
@ankona ankona enabled auto-merge (squash) February 29, 2024 22:44
@ankona ankona changed the title bump redis dep to 7.2.4 Update Redis dependency to 7.2.4 Feb 29, 2024
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-doing the line endings

@ankona ankona merged commit 63836a9 into CrayLabs:develop Feb 29, 2024
42 checks passed
@ankona ankona deleted the redis_724 branch April 4, 2024 19:32
@amandarichardsonn amandarichardsonn added bug: minor A minor bug repo: smartsim Issues related to SmartSim infrastructure library area: build Issues related to builds, makefiles, installs, etc labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Issues related to builds, makefiles, installs, etc bug: minor A minor bug repo: smartsim Issues related to SmartSim infrastructure library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants